(WIP) Unity Case Study – Refactoring “Tanks!” with SOLID Principles and Design Patterns

using System.Collections; using UnityEngine; using UnityEngine.SceneManagement; using UnityEngine.UI; namespace Complete { public class GameManager : MonoBehaviour { // This class violates SRP by handling multiple // responsibilities: // - UI/HUD message display // - Game loop control and timing // - Tank spawning and lifecycle management // - Camera target configuration // - Win condition detection // - Scene management and reloading public int m_NumRoundsToWin = 5; public float m_StartDelay = 3f; public float m_EndDelay = 3f; public CameraControl m_CameraControl; public Text m_MessageText; public GameObject m_TankPrefab; public TankManager[] m_Tanks; private int m_RoundNumber; private WaitForSeconds m_StartWait; private WaitForSeconds m_EndWait; private TankManager m_RoundWinner; private TankManager m_GameWinner; // Game Loop Control private void Start() { m_StartWait = new WaitForSeconds(m_StartDelay); m_EndWait = new WaitForSeconds(m_EndDelay); SpawnAllTanks(); SetCameraTargets(); StartCoroutine(GameLoop()); } // Tank Management: spawn/setup private void SpawnAllTanks() { for (int i = 0; i < m_Tanks.Length; i++) { m_Tanks[i].m_Instance = Instantiate( m_TankPrefab, m_Tanks[i].m_SpawnPoint.position, m_Tanks[i].m_SpawnPoint.rotation ) as GameObject; m_Tanks[i].m_PlayerNumber = i + 1; m_Tanks[i].Setup(); } } // Camera Management private void SetCameraTargets() { Transform[] targets = new Transform[m_Tanks.Length]; for (int i = 0; i < targets.Length; i++) { targets[i] = m_Tanks[i].m_Instance.transform; } m_CameraControl.m_Targets = targets; } // Game Loop Control private IEnumerator GameLoop() { yield return StartCoroutine(RoundStarting()); yield return StartCoroutine(RoundPlaying()); yield return StartCoroutine(RoundEnding()); if (m_GameWinner != null) { SceneManager.LoadScene(0); } else { StartCoroutine(GameLoop()); } } // Game Loop Control; UI/HUD private IEnumerator RoundStarting() { ResetAllTanks(); DisableTankControl(); m_CameraControl.SetStartPositionAndSize(); m_RoundNumber++; m_MessageText.text = "ROUND " + m_RoundNumber; yield return m_StartWait; } // Game Loop Control private IEnumerator RoundPlaying() { EnableTankControl(); m_MessageText.text = string.Empty; while (!OneTankLeft()) { yield return null; } } // Game Loop Control; Win Detection; UI/HUD private IEnumerator RoundEnding() { DisableTankControl(); m_RoundWinner = null; m_RoundWinner = GetRoundWinner(); if (m_RoundWinner != null) m_RoundWinner.m_Wins++; m_GameWinner = GetGameWinner(); string message = EndMessage(); m_MessageText.text = message; yield return m_EndWait; } // Win Detection private bool OneTankLeft() { int numTanksLeft = 0; for (int i = 0; i < m_Tanks.Length; i++) { if (m_Tanks[i].m_Instance.activeSelf) numTanksLeft++; } return numTanksLeft <= 1; } // Win Detection private TankManager GetRoundWinner() { for (int i = 0; i < m_Tanks.Length; i++) { if (m_Tanks[i].m_Instance.activeSelf) return m_Tanks[i]; } return null; } // Win Detection private TankManager GetGameWinner() { for (int i = 0; i < m_Tanks.Length; i++) { if (m_Tanks[i].m_Wins == m_NumRoundsToWin) return m_Tanks[i]; } return null; } // UI/HUD Management private string EndMessage() { string message = "DRAW!"; if (m_RoundWinner != null) message = m_RoundWinner.m_ColoredPlayerText + " WINS THE ROUND!"; message += "\n\n\n\n"; for (int i = 0; i < m_Tanks.Length; i++) { message += m_Tanks[i].m_ColoredPlayerText + ": " + m_Tanks[i].m_Wins + " WINS\n"; } if (m_GameWinner != null) message = m_GameWinner.m_ColoredPlayerText + " WINS THE GAME!"; return message; } // Tank Management private void ResetAllTanks() { for (int i = 0; i < m_Tanks.Length; i++) { m_Tanks[i].Reset(); } } // Tank Management private void EnableTankControl() { for (int i = 0; i < m_Tanks.Length; i++) { m_Tanks[i].EnableControl(); } } // Tank Management private void DisableTankControl() { for (int i = 0; i < m_Tanks.Length; i++) { m_Tanks[i].DisableControl(); } } } }